Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: OmniSciDB - Add support for within, d_fully_within and point #2125

Merged
merged 2 commits into from
Mar 14, 2020
Merged

FEAT: OmniSciDB - Add support for within, d_fully_within and point #2125

merged 2 commits into from
Mar 14, 2020

Conversation

xmnlab
Copy link
Contributor

@xmnlab xmnlab commented Mar 10, 2020

Resolves #1924

@xmnlab xmnlab mentioned this pull request Mar 10, 2020
Closed
@xmnlab xmnlab requested a review from jreback March 10, 2020 18:22
@xmnlab
Copy link
Contributor Author

xmnlab commented Mar 10, 2020

@jreback it is ready for review. thanks!

jreback
jreback suggested changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok, pls add a release note

@jreback
Copy link
Contributor

jreback commented Mar 12, 2020

does this fully close #1924?

@xmnlab xmnlab force-pushed the omniscidb-add-more-geostial-ops branch from 0d4128b to 3104036 Compare March 12, 2020 15:34
@xmnlab
Copy link
Contributor Author

xmnlab commented Mar 12, 2020

thanks for the review @jreback ! yes it fully resolves #1924
release note added.

@xmnlab
Copy link
Contributor Author

xmnlab commented Mar 12, 2020

ci is green

jreback
jreback suggested changes Mar 14, 2020
View reviewed changes
ibis/expr/api.py Outdated
@@ -2024,6 +2026,24 @@ def geo_overlaps(left, right):
return op.to_expr()


def geo_point(left, right):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you type

@xmnlab xmnlab force-pushed the omniscidb-add-more-geostial-ops branch from 3104036 to 84c56bb Compare March 14, 2020 03:59
@jreback jreback added this to the Next Feature Release milestone Mar 14, 2020
@jreback jreback merged commit 916f221 into ibis-project:master Mar 14, 2020
@jreback
Copy link
Contributor

jreback commented Mar 14, 2020

thanks @xmnlab

@xmnlab xmnlab deleted the omniscidb-add-more-geostial-ops branch March 14, 2020 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FEAT: Add new geospatial operations into OmniSciDB/MapD backend
2 participants
@xmnlab @jreback