Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: add translation rules for isnull() and notnull() for pyspark backend #2126

Merged
merged 5 commits into from
Mar 17, 2020
Merged

FEAT: add translation rules for isnull() and notnull() for pyspark backend #2126

merged 5 commits into from
Mar 17, 2020

Conversation

LeeTZ
Copy link
Contributor

@LeeTZ LeeTZ commented Mar 11, 2020

No description provided.

icexelloss
icexelloss reviewed Mar 11, 2020
View reviewed changes
ibis/pyspark/tests/conftest.py
[
[np.NaN, 'Alfred', None],
[27.0, 'Batman', 'motocycle'],
[3.0, None, 'joker'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is joker a toy? :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Ignore this comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will know if you figure out who is None :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Ignore this comment)

@icexelloss
Copy link
Contributor

LGTM. @jreback Can you take a look and merge if looks good to you too?

icexelloss
icexelloss approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@icexelloss icexelloss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@jreback jreback added feature Features or general enhancements pyspark The Apache PySpark backend labels Mar 12, 2020
jreback
jreback suggested changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, can you add a release note. ping on green.

@jreback jreback added this to the Next Bugfix Release milestone Mar 14, 2020
@jreback jreback merged commit 94cb1ce into ibis-project:master Mar 17, 2020
@jreback
Copy link
Contributor

jreback commented Mar 17, 2020

thanks @LeeTZ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icexelloss icexelloss icexelloss approved these changes

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
feature Features or general enhancements pyspark The Apache PySpark backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LeeTZ @icexelloss @jreback