BUG: [OmniSciDB] Fix TopK when used as filter #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmnlab
commented
Mar 12, 2020
| @@ -180,6 +180,7 @@ class OmniSciDBTableSetFormatter(compiles.TableSetFormatter): | |||
| _join_names = { | |||
| ops.InnerJoin: 'JOIN', | |||
| ops.LeftJoin: 'LEFT JOIN', | |||
| ops.LeftSemiJoin: 'JOIN', # needed by topk as filter | |||
There was a problem hiding this comment.
not sure if it is the best approach ... but at least it is working now.
maybe #512 would be a better approach to fix this issue
There was a problem hiding this comment.
that's a really old issue, has things changed in the interim?
There was a problem hiding this comment.
it seems it was not changed. but maybe we need to check this better.
jreback
suggested changes
Mar 12, 2020
ibis/file/parquet.py
Outdated
| def table(self, name, path): | ||
| def table( | ||
| self, name: str, path: Optional[str] = None | ||
| ) -> ibis.expr.types.TableExpr: |
There was a problem hiding this comment.
use the standard ibis import
import ibis.expr.types as ir (at the top)
xmnlab
force-pushed
the
omniscidb-bug-topk-join
branch
from
af3586b
to
63937d4
Compare
|
release note added and ci green. |
jreback
approved these changes
Mar 14, 2020
|
lgtm. tip on release notes; don't put them at the top, rather insert between others so to avoid conflicts. |
xmnlab
force-pushed
the
omniscidb-bug-topk-join
branch
from
cbfad05
to
2cd2274
Compare
|
thanks @xmnlab |
|
thanks @jreback for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1918 . Additionally fix #2129