Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Create ExtractDayOfYear operation and add its support to Clickhouse, CSV, MySQL, OmniSciDB, Pandas, Parquet, PostgreSQL, PySpark, SQLite and Spark #2173

Merged
merged 1 commit into from
May 26, 2020
Merged

FEAT: Create ExtractDayOfYear operation and add its support to Clickhouse, CSV, MySQL, OmniSciDB, Pandas, Parquet, PostgreSQL, PySpark, SQLite and Spark #2173

merged 1 commit into from
May 26, 2020

Conversation

xmnlab
Copy link
Contributor

@xmnlab xmnlab commented Apr 1, 2020 •
edited
Loading

Create ExtractDayOfYear operation and add its support to Clickhouse, CSV, MySQL, OmniSciDB, Pandas, Parquet, PostgreSQL, PySpark, SQLite and Spark

@xmnlab
Copy link
Contributor Author

xmnlab commented Apr 1, 2020

output from a local test:

(ibis-dev) ✔ ~/dev/quansight/ibis-project/ibis [create-op-day-of-year L|✚ 11] 
18:26 $ IBIS_TEST_MYSQL_PORT=3307 pytest -vv -x -k day_of_year ibis/tests/all/test_temporal.py::test_timestamp_extract
========================= test session starts =========================
platform linux -- Python 3.7.6, pytest-5.3.5, py-1.8.1, pluggy-0.13.0 -- /home/xmn/miniconda3/envs/ibis-dev/bin/python
cachedir: .pytest_cache
rootdir: /home/xmn/dev/quansight/ibis-project/ibis, inifile: setup.cfg
plugins: mock-2.0.0, cov-2.8.1, xdist-1.31.0, forked-1.1.2
collected 91 items / 78 deselected / 13 selected                      

ibis/tests/all/test_temporal.py::test_timestamp_extract[BigQuery-day_of_year] SKIPPED [  7%]
ibis/tests/all/test_temporal.py::test_timestamp_extract[Clickhouse-day_of_year] PASSED [ 15%]
ibis/tests/all/test_temporal.py::test_timestamp_extract[Csv-day_of_year] PASSED [ 23%]
ibis/tests/all/test_temporal.py::test_timestamp_extract[HDF5-day_of_year] SKIPPED [ 30%]
ibis/tests/all/test_temporal.py::test_timestamp_extract[Impala-day_of_year] XFAIL [ 38%]
ibis/tests/all/test_temporal.py::test_timestamp_extract[MySQL-day_of_year] PASSED [ 46%]
ibis/tests/all/test_temporal.py::test_timestamp_extract[OmniSciDB-day_of_year] PASSED [ 53%]
ibis/tests/all/test_temporal.py::test_timestamp_extract[Pandas-day_of_year] PASSED [ 61%]
ibis/tests/all/test_temporal.py::test_timestamp_extract[Parquet-day_of_year] PASSED [ 69%]
ibis/tests/all/test_temporal.py::test_timestamp_extract[PostgreSQL-day_of_year] PASSED [ 76%]
ibis/tests/all/test_temporal.py::test_timestamp_extract[PySpark-day_of_year] PASSED [ 84%]
ibis/tests/all/test_temporal.py::test_timestamp_extract[SQLite-day_of_year] PASSED [ 92%]
ibis/tests/all/test_temporal.py::test_timestamp_extract[Spark-day_of_year] PASSED [100%]

====== 10 passed, 2 skipped, 78 deselected, 1 xfailed in 24.97s =======

xmnlab
xmnlab commented Apr 1, 2020
View reviewed changes
ci/docker-compose.yml Outdated Show resolved Hide resolved
@xmnlab xmnlab mentioned this pull request Apr 4, 2020
Merged
@xmnlab xmnlab force-pushed the create-op-day-of-year branch 2 times, most recently from 31c3733 to d12064f Compare April 7, 2020 14:05
@xmnlab xmnlab marked this pull request as ready for review April 7, 2020 15:02
@xmnlab
Copy link
Contributor Author

xmnlab commented Apr 7, 2020

it is ready for review :)

@jreback jreback added the feature Features or general enhancements label Apr 9, 2020
@jreback jreback added this to the Next Feature Release milestone Apr 9, 2020
@jreback
Copy link
Contributor

jreback commented Apr 9, 2020

looks fine, can you rebase and ping on green.

@xmnlab
FEAT: Create ExtractDayOfYear operation and add its support to Clickh…
daaaa92 
…ouse, CSV, MySQL, OmniSciDB, Pandas, Parquet, PostgreSQL, PySpark, SQLite and Spark
jreback
jreback approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine thanks

@jreback jreback merged commit e66a167 into ibis-project:master May 26, 2020
@xmnlab xmnlab deleted the create-op-day-of-year branch May 26, 2020 16:30
@xmnlab xmnlab mentioned this pull request Jul 26, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
feature Features or general enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xmnlab @jreback