Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Create ExtractQuarter operation and add its support to Clickhouse, CSV, Impala, MySQL, OmniSciDB, Pandas, Parquet, PostgreSQL, PySpark, SQLite and Spark #2175

Merged
merged 1 commit into from
May 26, 2020
Merged

FEAT: Create ExtractQuarter operation and add its support to Clickhouse, CSV, Impala, MySQL, OmniSciDB, Pandas, Parquet, PostgreSQL, PySpark, SQLite and Spark #2175

merged 1 commit into from
May 26, 2020

Conversation

xmnlab
Copy link
Contributor

@xmnlab xmnlab commented Apr 1, 2020

Create ExtractQuarter operation and add its support to Clickhouse, CSV, Impala, MySQL, OmniSciDB, Pandas, Parquet, PostgreSQL, PySpark, SQLite and Spark

@xmnlab
Copy link
Contributor Author

xmnlab commented Apr 2, 2020

the output from the local tests was:

IBIS_TEST_MYSQL_PORT=3307 pytest -vv -x -k quarter ibis/tests/all/test_temporal.py::test_timestamp_extract
========================= test session starts =========================
platform linux -- Python 3.7.6, pytest-5.3.5, py-1.8.1, pluggy-0.13.0 -- /home/xmn/miniconda3/envs/ibis-dev/bin/python
cachedir: .pytest_cache
rootdir: /home/xmn/dev/quansight/ibis-project/ibis, inifile: setup.cfg
plugins: mock-2.0.0, cov-2.8.1, xdist-1.31.0, forked-1.1.2
collected 91 items / 78 deselected / 13 selected                      

ibis/tests/all/test_temporal.py::test_timestamp_extract[BigQuery-quarter] SKIPPED [  7%]
ibis/tests/all/test_temporal.py::test_timestamp_extract[Clickhouse-quarter] PASSED [ 15%]
ibis/tests/all/test_temporal.py::test_timestamp_extract[Csv-quarter] PASSED [ 23%]
ibis/tests/all/test_temporal.py::test_timestamp_extract[HDF5-quarter] SKIPPED [ 30%]
ibis/tests/all/test_temporal.py::test_timestamp_extract[Impala-quarter] PASSED [ 38%]
ibis/tests/all/test_temporal.py::test_timestamp_extract[MySQL-quarter] PASSED [ 46%]
ibis/tests/all/test_temporal.py::test_timestamp_extract[OmniSciDB-quarter] PASSED [ 53%]
ibis/tests/all/test_temporal.py::test_timestamp_extract[Pandas-quarter] PASSED [ 61%]
ibis/tests/all/test_temporal.py::test_timestamp_extract[Parquet-quarter] PASSED [ 69%]
ibis/tests/all/test_temporal.py::test_timestamp_extract[PostgreSQL-quarter] PASSED [ 76%]
ibis/tests/all/test_temporal.py::test_timestamp_extract[PySpark-quarter] PASSED [ 84%]
ibis/tests/all/test_temporal.py::test_timestamp_extract[SQLite-quarter] PASSED [ 92%]
ibis/tests/all/test_temporal.py::test_timestamp_extract[Spark-quarter] PASSED [100%]

============ 11 passed, 2 skipped, 78 deselected in 23.56s ============

@xmnlab xmnlab marked this pull request as ready for review April 2, 2020 15:34
@xmnlab
Copy link
Contributor Author

xmnlab commented Apr 2, 2020

it is ready for review. thanks!

@xmnlab xmnlab force-pushed the create-op-extract-quarter branch from 9c7445a to 9afc439 Compare April 5, 2020 01:43
@xmnlab xmnlab force-pushed the create-op-extract-quarter branch from 9afc439 to dd10aee Compare May 26, 2020 14:44
@jreback jreback added the feature Features or general enhancements label May 26, 2020
@jreback jreback added this to the Next Feature Release milestone May 26, 2020
@jreback
Copy link
Contributor

jreback commented May 26, 2020

can you rebase

@xmnlab
FEAT: Create ExtractQuarter operation and add its support to Clickhou…
8e83831 
…se, CSV, Impala, MySQL, OmniSciDB, Pandas, Parquet, PostgreSQL, PySpark, SQLite and Spark
@xmnlab xmnlab force-pushed the create-op-extract-quarter branch from dd10aee to 8e83831 Compare May 26, 2020 16:27
@xmnlab
Copy link
Contributor Author

xmnlab commented May 26, 2020

@jreback it was rebased! thanks!

@jreback jreback merged commit 4f12fd0 into ibis-project:master May 26, 2020
@jreback
Copy link
Contributor

jreback commented May 26, 2020

thanks

@xmnlab xmnlab mentioned this pull request Jul 26, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
feature Features or general enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xmnlab @jreback