Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: implement 'ZeroIfNull' and 'NullIfZero' for omnisci backend #2186

Merged
merged 9 commits into from
May 26, 2020
Merged

FEATURE: implement 'ZeroIfNull' and 'NullIfZero' for omnisci backend #2186

merged 9 commits into from
May 26, 2020

Conversation

dchigarev
Copy link
Contributor

Added support of nullifzero and zeroifnull for omnisci, implemented via nullif and fillna

@pep8speaks
Copy link

pep8speaks commented Apr 17, 2020 •
edited
Loading

Hello @dchigarev! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-05-26 12:39:27 UTC

@dchigarev
Copy link
Contributor Author

@xmnlab could you review this PR?)

@jreback jreback added this to the Next Bugfix Release milestone May 25, 2020
@jreback
Copy link
Contributor

jreback commented May 25, 2020

looks ok, can you add a release note.

@jreback jreback merged commit 323f48f into ibis-project:master May 26, 2020
@jreback
Copy link
Contributor

jreback commented May 26, 2020

thanks @dchigarev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dchigarev @pep8speaks @jreback