Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Add window ops support to SQLite #2232

Merged
merged 1 commit into from
Jun 18, 2020
Merged

FEAT: Add window ops support to SQLite #2232

merged 1 commit into from
Jun 18, 2020

Conversation

xmnlab
Copy link
Contributor

@xmnlab xmnlab commented Jun 2, 2020 •
edited
Loading

This PR adds window operations support to SQLite

Resolve #2231

@xmnlab xmnlab force-pushed the add-sqlite-window-ops-support branch from 66fa969 to 5523aee Compare June 2, 2020 23:42
@xmnlab xmnlab mentioned this pull request Jun 3, 2020
Closed
@xmnlab xmnlab marked this pull request as ready for review June 3, 2020 15:56
@xmnlab
Copy link
Contributor Author

xmnlab commented Jun 3, 2020

this PR is ready for review. thanks!

@xmnlab
Copy link
Contributor Author

xmnlab commented Jun 10, 2020

a friendly reminder about this PR. thanks!

@xmnlab xmnlab added sqlite The SQLite backend window functions Issues or PRs related to window functions labels Jun 10, 2020
@xmnlab xmnlab changed the title Add window ops support to SQLite FEAT: Add window ops support to SQLite Jun 10, 2020
@xmnlab xmnlab force-pushed the add-sqlite-window-ops-support branch from 5523aee to 92708ca Compare June 12, 2020 20:08
@xmnlab
Copy link
Contributor Author

xmnlab commented Jun 12, 2020

ibis-project.ibis (LinuxTest py38_impala_kudu_clickhouse) tests passed. but Publish Linux environment YAML to Azure raised an error:

Information, ApplicationInsightsTelemetrySender correlated 2 events with X-TFS-Session dba36af5-380b-4393-8afc-9018370188b1
##[error]Artifact LinuxCondaEnvironment-38-main already exists for build 2597.
Finishing: Publish Linux environment YAML to Azure

probably it is not a block for review or merge.

it is ready again for review. thanks!

@icexelloss icexelloss self-requested a review June 18, 2020 14:26
icexelloss
icexelloss approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@icexelloss icexelloss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you re trigger the CI to see if the failure goes away?

@xmnlab xmnlab force-pushed the add-sqlite-window-ops-support branch from 92708ca to 7746fc5 Compare June 18, 2020 14:51
@xmnlab
Copy link
Contributor Author

xmnlab commented Jun 18, 2020

thanks @icexelloss ! branch rebased.

@jreback jreback added this to the Next Feature Release milestone Jun 18, 2020
@jreback jreback merged commit a32dc3b into ibis-project:master Jun 18, 2020
@jreback
Copy link
Contributor

jreback commented Jun 18, 2020

thanks @xmnlab

@xmnlab xmnlab deleted the add-sqlite-window-ops-support branch December 21, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icexelloss icexelloss icexelloss approved these changes

Assignees
No one assigned
Labels
sqlite The SQLite backend window functions Issues or PRs related to window functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENH: Add support for window operation to ibis.sqlite
3 participants
@xmnlab @jreback @icexelloss