-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Implement ibis.pandas.trace module to add time and call stack informa… #2233
Conversation
…tion for pandas backend
|
looks pretty good i think makes sense to hook this into config: https://github.com/ibis-project/ibis/blob/master/ibis/config_init.py then i think u can instrument always and just hide it behind the flag |
|
Thanks @jreback. Make sense, let me hook this into the config. |
|
LGTM |
|
@jreback Updated! Can you take another look please? |
| 'enable_trace', | ||
| False, | ||
| """ | ||
| Whether enable tracing for pandas execution. See ibis.panads.trace for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sp? here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I don't quite get that. What do you by sp?
| return traced_func | ||
|
|
||
|
|
||
| class TraceDispatcher(Dispatcher): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this additional complexity here? can you just modify Dispatcher to add (if the config is on)? isn't that the point of using the option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dispatcher is from multipledispatch library..
|
lgtm @icexelloss |
|
its going to run the CI again as conflict in the release note, but can merge on green. |
|
thanks @icexelloss |
What is the change
This PR add a way to log time and call stack information for pandas backend.
The information can be enabled by turning logging level to DEBUG.
e.g.
Output:
How is the change tested
This is manually tested. If you have some ideas how to test this I am happy to hear.