Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Add missing float types to pandas backend #2237

Merged

Conversation

zbrookle
Copy link
Contributor

@zbrookle zbrookle commented Jun 7, 2020

Adds missing types float16, float32, and float64 to pandas backend. Closes #2235

@jreback jreback added the compatibility Compatibility related issues or PRs label Jun 9, 2020
@jreback jreback added this to the Next Bugfix Release milestone Jun 9, 2020
@jreback
Copy link
Contributor

jreback commented Jun 9, 2020

yeah I don't remember why these were left off from casting originally, but looks ok. can you add a release note. ping on green.

@zbrookle
Copy link
Contributor Author

zbrookle commented Jun 9, 2020

@jreback Added a release note

Copy link
Contributor

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed conflict, merging on green. Thanks @zbrookle

@datapythonista datapythonista merged commit 86f4b26 into ibis-project:master Jun 30, 2020
@datapythonista
Copy link
Contributor

Thanks @zbrookle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Compatibility related issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Pandas backend missing float16 and float32 type
3 participants