Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stable version of OmniSciDB on CI #2244

Merged
merged 2 commits into from
Jun 14, 2020
Merged

Use stable version of OmniSciDB on CI #2244

merged 2 commits into from
Jun 14, 2020

Conversation

xmnlab
Copy link
Contributor

@xmnlab xmnlab commented Jun 11, 2020

depends on #2242

jreback
jreback suggested changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a note in the release notes. Is there a specif version of pymapd, e.g. do we have a min spec on this?

@xmnlab
Copy link
Contributor Author

xmnlab commented Jun 12, 2020

thanks @jreback I will add a release note for that.
currently ibis is pinning pymapd to 0.22 (the latest version) mostly because pyarrow conflicts with other libraries used by other ibis backends.

@xmnlab xmnlab marked this pull request as ready for review June 13, 2020 19:47
@jreback jreback added this to the Next Feature Release milestone Jun 14, 2020
@jreback jreback merged commit d8ca6bd into ibis-project:master Jun 14, 2020
@jreback
Copy link
Contributor

jreback commented Jun 14, 2020

ok this is fine. note that we will only change the stable version now on a slower basis.

@xmnlab
Copy link
Contributor Author

xmnlab commented Jun 14, 2020

thanks @jreback !

@xmnlab xmnlab deleted the update-omniscidb-image branch June 14, 2020 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xmnlab @jreback