Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to handle change in sql_validate return type #2256

Closed
wants to merge 4 commits into from

Conversation

jclay
Copy link

@jclay jclay commented Jun 24, 2020

This is to accommodate the changes made to the OmniSci client in heavyai/pymapd#325

Copy link
Contributor

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jclay. Do we need to require a higher version of pymapd after this change?

Also, would be good to have a test, and an entry in the release notes. Thanks!

@jclay jclay force-pushed the jclay/omnisci_thrift_update branch from 3590315 to fcb4429 Compare July 8, 2020 01:28
@jclay
Copy link
Author

jclay commented Jul 8, 2020

@datapythonista I have updated the CI suite to use the latest pymapd released today. I will open a PR on the feedstock repo as well.

Note that this was only affecting OmnisciDB v5.3.0 users, so while Ibis had good test coverage for this already, we were testing against v5.2.2 so it was not showing up in the tests. I have added coverage of sql_validate functionality on the pymapd side.

I'm not sure if it's related to the pymapd version bump, but I am noticing a drastic increase in the time it takes for conda to resolve the dependency constraints. Once cudf 0.15 is released, we should be able to relax some of the dependency constraints on the pymapd side.

@xmnlab
Copy link
Contributor

xmnlab commented Jul 8, 2020

mmm for some reason it is raising this error:

ibis/omniscidb/tests/test_operations.py:87: AssertionError

not sure why it is changing the result size:

>       assert df.size == 80
E       assert 70 == 80

@datapythonista
Copy link
Contributor

@jclay, pymapd=0.24 was giving us problems in the CI, conda never finished to solve the environment, and we had to pin the version to 0.23 in #2272. Does this PR still makes sense?

You can investigate the problems with pymapd and conda, but for now we'll keep pinning to a specific version, and upgrade only when we know that the solver is not causing trouble.

@datapythonista
Copy link
Contributor

@jclay is this something we still want to get merged?

@jclay
Copy link
Author

jclay commented Jul 27, 2020

I think we will want to get this merged at some point given it fixes the sql_execute breakage we were seeing on OmniSci 5.3. Let me close this out for now until I have a chance to revisit and get the failing test resolved.

@tmostak
Copy link

tmostak commented Oct 21, 2020

Hi @jclay, any update on this? Spoke to Eric K and he mentioned it was causing major headaches for a prospect.

@xmnlab xmnlab mentioned this pull request Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants