FEAT: Support custom window in pandas backend #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expected_1 = pd.Series([4.0, 10.0, 5.0]) | ||
|
|
||
| tm.assert_series_equal(result_0, expected_0) | ||
| tm.assert_series_equal(result_1, expected_1) |
There was a problem hiding this comment.
Not sure if it'd be more conventional to use a fixture for all the custom objects, and parameterize this. But happy to have it like this, if we don't expect to reuse all the custom objects.
There was a problem hiding this comment.
can also parametrize this test with the different cases
There was a problem hiding this comment.
Made those fixtures
|
Thanks @jreback @datapythonista for the review! I addressed all the comments. Please take another look when you got the chance, thank you! |
datapythonista
approved these changes
Jul 1, 2020
jreback
suggested changes
Jul 1, 2020
Co-authored-by: Marc Garcia <garcia.marc@gmail.com>
Co-authored-by: Marc Garcia <garcia.marc@gmail.com>
icexelloss
force-pushed
the
pandas-custom-window
branch
from
c942424
to
532d8c3
Compare
jreback
approved these changes
Jul 1, 2020
|
thanks @icexelloss |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the existing pandas window execution to allow implementing custom window with pandas backend.
The change is tested with a new test
test_custom_window_udfwhich implements a dummy custom window and test it with pandas backend.