FEAT: Add support for Union in PySpark backend #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icexelloss
suggested changes
Jul 9, 2020
ibis/pyspark/tests/test_basic.py
Outdated
| @@ -163,6 +163,25 @@ def test_filter(client, filter_fn, expected_fn): | |||
| tm.assert_frame_equal(result.toPandas(), expected.toPandas()) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize('distinct', [False, True]) | |||
| def test_union(client, distinct): | |||
There was a problem hiding this comment.
Do we have union tests under tests/all?
There was a problem hiding this comment.
I think I can move this test to tests/all actually
There was a problem hiding this comment.
I created a new union test in tests/all and removed the union test in the PySpark backend I was originally going to add. I also removed the existing basic union tests in the Pandas and Postgres backends
icexelloss
approved these changes
Jul 10, 2020
|
LGTM. Can merge if CI passes. |
timothydijamco
force-pushed
the
pyspark-union
branch
from
716cb64
to
81fa05b
Compare
|
Rebased since CI has been fixed (in #2272) |
added 3 commits
July 13, 2020 22:54
|
Going to rebase again now that the CI |
timothydijamco
force-pushed
the
pyspark-union
branch
from
313b7eb
to
7a2d837
Compare
|
thanks @timothydijamco |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a compilation function for the
Unionnode in the PySpark backend (roughly mirroring the execution function forUnionin the Pandas backend).Testing
Added a new test in
pyspark/tests/test_basic.pyto test the compilation function (exposed byunionin the table API)