Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add category integration for cast to pandas backend #2285

Merged
merged 2 commits into from
Jul 20, 2020
Merged

ENH: Add category integration for cast to pandas backend #2285

merged 2 commits into from
Jul 20, 2020

Conversation

zbrookle
Copy link
Contributor

Noticed that you couldn't use cast with the dtype category

@jreback jreback added the expressions Issues or PRs related to the expression API label Jul 20, 2020
@jreback jreback added this to the Next Bugfix Release milestone Jul 20, 2020
jreback
jreback suggested changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a release note, can you create an issue to enable this on other backend (do the SQL backends support this?

@zbrookle
Copy link
Contributor Author

@jreback Sounds good, I'll add a release note. I'm pretty sure category isn't really a SQL data type in most dialects, but I can add an issue to look into it

@jreback jreback merged commit fd5b8bd into ibis-project:master Jul 20, 2020
@jreback
Copy link
Contributor

jreback commented Jul 20, 2020

thanks @zbrookle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
expressions Issues or PRs related to the expression API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zbrookle @jreback