SUPP: update min google-cloud-bigquery version #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswast
force-pushed
the
user-agent-version-bump
branch
from
047eab9
to
a775306
Compare
|
Windows test failure seems unrelated to this change |
|
Yes, thanks. I'm aware, the whole CI is broken again. I'm trying to simplify things in the CI, so it breaks less, or at least is easier to fix when it breaks, but it'll take me some time. |
|
@tswast you'll have to redo this, sorry. All those requirement files do not exist anymore, now bigquery dependencies are in |
This is needed in order to set the application name in the user agent header. This feature to be added in: ibis-project#2303 Also: * Remove pin on google-api-core, now that googleapis/python-api-core#47 is closed. * Update docs/source/release/index.rst Co-authored-by: Marc Garcia <garcia.marc@gmail.com>
tswast
force-pushed
the
user-agent-version-bump
branch
from
a775306
to
b45e832
Compare
Done! |
jreback
suggested changes
Aug 13, 2020
It's there, I think you checked the diff of the last commit ;) |
jreback
approved these changes
Aug 13, 2020
|
great, lgtm. |
|
Thanks @tswast |
LeeTZ
pushed a commit
to LeeTZ/ibis
that referenced
this pull request
Sep 4, 2020
This is needed in order to set the application name in the user agent header. This feature to be added in: ibis-project#2303 Also: * Remove pin on google-api-core, now that googleapis/python-api-core#47 is closed. * Update docs/source/release/index.rst Co-authored-by: Marc Garcia <garcia.marc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed in order to set the application name in the user agent
header. This feature to be added in:
#2303
Also, removes pin on google-api-core, now that
googleapis/python-api-core#47 is closed.