Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add table except #2347

Merged
merged 12 commits into from
Sep 2, 2020
Merged

Add table except #2347

merged 12 commits into from
Sep 2, 2020

Conversation

zbrookle
Copy link
Contributor

This pull request adds the SQL 'EXCEPT' functionality, which is the set difference. I followed the same format as intersect so it should be fairly straightforward

datapythonista
datapythonista approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @zbrookle

ibis/sql/compiler.py Outdated Show resolved Hide resolved
@datapythonista datapythonista added feature Features or general enhancements expressions Issues or PRs related to the expression API labels Sep 1, 2020
@zbrookle @datapythonista
REF: Clean up EXCEPT logic
e4c4ded 
Co-authored-by: Marc Garcia <garcia.marc@gmail.com>
jreback
jreback suggested changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. can you add a whatsnew note.

also I think we should have a small section in the tutorial on using the set ops on tables, but let's make an issue about that (and of course if you want to contribute to that would be great).

ping on green.

@jreback jreback added this to the Next Feature Release milestone Sep 2, 2020
@zbrookle
Copy link
Contributor Author

zbrookle commented Sep 2, 2020

@jreback I know this is a feature but would it be possible to have it in the next bug fix release so that it gets shipped alongside the intersection feature from #2250 ?

@jreback
Copy link
Contributor

jreback commented Sep 2, 2020

@jreback I know this is a feature but would it be possible to have it in the next bug fix release so that it gets shipped alongside the intersection feature from #2250 ?

these are just labels am assigning. we havent' been doing bug fix releases anyhow (only major ones), so will be included.

@zbrookle
Copy link
Contributor Author

zbrookle commented Sep 2, 2020

@jreback Ok sounds good!

@jreback jreback merged commit e55e96b into ibis-project:master Sep 2, 2020
@jreback
Copy link
Contributor

jreback commented Sep 2, 2020

thanks @zbrookle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@datapythonista datapythonista datapythonista approved these changes

Assignees
No one assigned
Labels
expressions Issues or PRs related to the expression API feature Features or general enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zbrookle @jreback @datapythonista