TST: Making tests directory structure simpler #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datapythonista
added
refactor
jreback
suggested changes
Sep 3, 2020
jreback
approved these changes
Sep 4, 2020
|
thanks @datapythonista |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently many directories with tests. Since backend tests directories need to skipped when their container is not loaded, this means that we can't simply call
pytest ibis/. Which means that we need to callpytest ibis/tests ibis/expr/tests ibis/sql/tests.... This is a bit complex, both in the CI and locally. Grouping all the tests in a single directory seems to make more sense, sopytest ibis/testscan be used.Same happens with backend tests, that some times are split in more than one directory.
This PR simplifies the structure. Ideally, at some point we'd like to have a more consistent and uniform backend structure (see #2336), which will simplify this further.