FEAT: Add PySpark support for ReductionVectorizedUDF #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be ideal if #2364 gets merged before this does, but it's not strictly necessary Merging #2364 before this would formally ensure these changes work with PySpark 3 (although I have verified this already in #2348) Not merging #2364 before this is OK as we'd still be testing using the old paradigm of testing only on PySpark 2 (and then #2364 would later ensure the changes in this PR work with PySpark 3) |
jreback
added
pyspark
icexelloss
reviewed
Sep 8, 2020
icexelloss
reviewed
Sep 8, 2020
icexelloss
reviewed
Sep 8, 2020
icexelloss
suggested changes
Sep 8, 2020
|
LGTM. I don't think getting #2364 merged is prerequisite because this PR already makes sure this works for Spark 2. Getting Spark 3 to work is orthogonal and can be done in 2364. |
jreback
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-make of #2348.
Change
Add a compilation function for
ReductionVectorizedUDFfor the PySpark backendTesting
test_vectorized_udf.py: New basic test for reduction UDFtest_aggregation.py: New test parameter (that uses reduction UDFs) fortest_aggregateandtest_aggregate_groupedtest_window.py: New test for unbounded window, including a test parameter that uses reduction UDFs