Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare to move hdfs functions to impala backend #2497

Merged
merged 5 commits into from
Oct 30, 2020
Merged

Prepare to move hdfs functions to impala backend #2497

merged 5 commits into from
Oct 30, 2020

Conversation

datapythonista
Copy link
Contributor

hdfs functions are specific to the Impala backend, but live in the top ibis namespace.

So far making them available in the impala namespace and showing a FutureWarning if they are called from the ibis namespace.

In short, users will be using ibis.impala.HDFS instead of ibis.HDFS (and same for WebHDFS and hdfs_connect).

@datapythonista datapythonista added refactor Issues or PRs related to refactoring the codebase hdfs impala The Apache Impala backend labels Oct 26, 2020
@datapythonista
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@datapythonista datapythonista mentioned this pull request Oct 30, 2020
Closed
@jreback jreback added this to the Next Feature Release milestone Oct 30, 2020
jreback
jreback approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. can you create an issue for removing this deprecation itself.

@jreback jreback merged commit 9fdc4ec into ibis-project:master Oct 30, 2020
@datapythonista datapythonista mentioned this pull request Oct 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
impala The Apache Impala backend refactor Issues or PRs related to refactoring the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@datapythonista @jreback