FEAT: Implement Not operation in PySpark backend #2607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icexelloss
commented
Feb 3, 2021
| ) | ||
| @pytest.mark.skip_backends(['dask']) # TODO - sorting - #2553 | ||
| @pytest.mark.xfail_unsupported | ||
| def test_filter(backend, alltypes, sorted_df, predicate_fn, expected_fn): |
There was a problem hiding this comment.
I didn't find a filter test in backends test so I added this.
|
cool, can you add a release note, ping on green. |
icexelloss
force-pushed
the
pyspark-not
branch
from
0bdac51
to
27d29f1
Compare
jreback
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be self explanatory.