FEAT: Add support for case/when in PySpark backend #2610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icexelloss
changed the title
icexelloss
force-pushed
the
pyspark-substr-null
branch
8 times, most recently
from
4c7d0cf
to
fc6239a
Compare
jreback
suggested changes
Feb 4, 2021
| if isinstance(start, pyspark.sql.Column) or isinstance( | ||
| length, pyspark.sql.Column | ||
| ): | ||
| raise NotImplementedError( |
There was a problem hiding this comment.
This is covered by this:
https://github.com/ibis-project/ibis/blob/master/ibis/backends/tests/test_string.py#L216
When catching NotImplemenntedError, the test will be xfailed.
icexelloss
force-pushed
the
pyspark-substr-null
branch
from
fc6239a
to
bde12e7
Compare
icexelloss
force-pushed
the
pyspark-substr-null
branch
from
bde12e7
to
b3c4b16
Compare
jreback
approved these changes
Feb 4, 2021
gerrymanoim
added a commit
to gerrymanoim/ibis
that referenced
this pull request
Feb 9, 2021
Looks like it was accidentally dropped in ibis-project#2610
gerrymanoim
added a commit
to gerrymanoim/ibis
that referenced
this pull request
Feb 10, 2021
Looks like it was accidentally dropped in ibis-project#2610
jreback
pushed a commit
that referenced
this pull request
Feb 10, 2021
Looks like it was accidentally dropped in #2610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the change
How is this tested
Add test under test_string.py for
substrAdd test under test_generic.py for
case/when