FEAT: Add auth_local_webserver, auth_external_data, and auth_cache to BigQuery connect #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
options to BigQuery connect These options control user-based authentication.
|
Here's a video demonstrating this new feature https://www.youtube.com/watch?v=UMWMnlA54Ys The Google verification team requested it. |
|
Since these features require a user to open a browser window, testing them in CI isn't really feasible. I can add some mocked unit tests if desired. |
that would be good to at least ensure the paths are exercised |
|
@jreback I've added unit tests. CI is green. |
|
thanks @tswast very nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2179
In order to verify the application, I need to submit a video demonstrating the need for the requested scopes. I realized that we don't make it easy to query data in Google Drive, so this PR remedies that.