BUG: Fix range_window for base_sql backend (continued) #2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix_base_sql_range_window
…ix_base_sql_range_window
|
The CI is passing now The pre-merge CI does not test BigQuery, but it does hit the relevant code when it tests the other SQL backends. I also confirmed locally that the current state of the PR resolves the error with the BigQuery backend mentioned in #2608. |
jreback
suggested changes
Mar 25, 2021
ibis/backends/base_sql/__init__.py
Outdated
| } | ||
|
|
||
|
|
||
| def _replace_interval_with_scalar(expr): |
jreback
approved these changes
Mar 25, 2021
|
thanks @timothydijamco and @LeeTZ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2608
This PR is a duplicate of #2614 (includes @LeeTZ 's bug fix and new test) + additional changes from me to debug the new test failing on some backends. (Creating a new PR just to make it easier for me to iterate and check if CI passes).
Please see #2614 for a full description of the original problem / solution