Support comparison of ColumnExpr to timestamp literal #2808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
pandas
|
lgtm can you add a whatsnew note (do we have an issue for this)? if not just put this PR number. merge master and ping on green. |
emilyreff7
changed the title
emilyreff7
changed the title
emilyreff7
force-pushed
the
timestamp-comparison
branch
from
4815da0
to
4d6ceaf
Compare
jreback
approved these changes
Jun 3, 2021
|
thanks @emilyreff7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
This PR adds support to execute the following types of expressions that compare a ColumnExpr to a timestamp literal, which was previously missing functionality in the Pandas and Dask backends:
Tests
Added tests for all comparison operations in test_temporal.py.