-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: .cast() to array outputs list instead of np.array in Pandas backend
#2821
BUG: .cast() to array outputs list instead of np.array in Pandas backend
#2821
Conversation
.cast() to array outputs list instead of np.array in Pandas backend
|
LGTM. Minor comment. |
|
@gerrymanoim This PR is breaking cast-to-array on the Dask backend. I've xfailed the test that was failing. #2743 will fix this. Does that sound reasonable to you? I'd also be happy to instead create a working Dask-specific execution function for |
|
lgtm @timothydijamco ping when ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
thanks, should be all set @jreback |
|
thanks @timothydijamco |
Problem
In the Pandas backend, when casting a column to an array type, a
listis created as the output instead of anp.array(which is the new standard in the Pandas backend).Solution
Change the Pandas backend implementation of the cast operation to produce a
np.array.