CLN: Unify database methods in SQLAlchemy backends #2862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datapythonista
added
refactor
|
can you rebase. note I am not sure if these are really tested that well. |
|
jreback
reviewed
Jul 15, 2021
|
|
||
| def list_schemas(self): | ||
| warnings.warn( | ||
| '`list_schemas` is deprecated, use `list_databases` instead', |
There was a problem hiding this comment.
can you add a test for this. Also we should create an issue with deprecations as a reminder to remove them.
4 tasks
jreback
reviewed
Jul 19, 2021
|
looks fine can you rebase |
jreback
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving duplicated methods from SQLAlchemy backends to base alchemy backend.
For
list_databasesandlist_schemas, they do the same thing (in different ways) except for postgres. In all other backendslist_databasesis used, solist_schemasis deprecated everywhere except in postgres.