Support summarization of empty data in Pandas backend #2908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datapythonista
approved these changes
Aug 21, 2021
ibis/expr/schema.py
Outdated
| series = [data.apply(lambda t: t[i]) for i in range(num_cols)] | ||
| result = pd.concat(series, axis=1) | ||
| if not len(data): | ||
| result = pd.concat([data], axis=1) |
There was a problem hiding this comment.
Why not result = data.to_frame()?
There was a problem hiding this comment.
Good point, updated to use to_frame instead.
emilyreff7
force-pushed
the
empty-summarization-fix
branch
from
f6ae051
to
614344e
Compare
datapythonista
added
dask
|
Thanks @emilyreff7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Handle empty input data in summarization.
Currently, when a summarization gets passed empty data in the Pandas backend, we error out with a confusing
This PR adds checks in a couple of places for empty data, such that we gracefully return an empty DataFrame instead.
Tests
Added a new test for this in test_vectorized_udf.py.