fix: Change map to geo_equals #2956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
suggested changes
Sep 10, 2021
| @pytest.mark.xfail_unsupported | ||
| def test_geo_equals(backend, geo): | ||
| """ | ||
| Test geo_equals/equals. |
There was a problem hiding this comment.
reference the issue in a comment. the Notes section is not needed here
jreback
approved these changes
Sep 10, 2021
|
@jreback thanks for the review. I added the release note and also changed 2 tests that were using I also updated the documentation about |
datapythonista
approved these changes
Sep 10, 2021
| assert expr.execute().all() | ||
|
|
||
| expr = geotable.geo_point.geo_equals(geotable.geo_linestring) | ||
| assert not expr.execute().all() |
There was a problem hiding this comment.
Do you want all them to be different? Then any should be better I think.
There was a problem hiding this comment.
that makes sense. I will change it now. thanks @datapythonista
|
thanks @xmnlab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the problem with
geo_equals.Currently,
equalsoperation is mapped togeo_equalsand it is given problems as reported at #2197Fix #2197