Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix literal of Nullable in Clickhouse #2985

Merged
merged 4 commits into from
Sep 20, 2021
Merged

fix: fix literal of Nullable in Clickhouse #2985

merged 4 commits into from
Sep 20, 2021

Conversation

Lunaticus7
Copy link
Contributor

Split from #2983

When literal None to some Nullable column's type will raise error.

expr = table.mutate(ibis.literal(None, table['nullable_string_column'].type()).name('new_column'))
expr.compile()
# AttributeError: 'NoneType' object has no attribute 'replace'

@Lunaticus7 Lunaticus7 mentioned this pull request Sep 18, 2021
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2021 •
edited
Loading

Unit Test Results

       19 files         19 suites   1h 42m 45s ⏱️
10 757 tests   8 403 ✔️   2 354 💤 0 ❌
54 463 runs  41 189 ✔️ 13 274 💤 0 ❌

Results for commit 161a90a.

♻️ This comment has been updated with latest results.

@cpcloud cpcloud self-requested a review September 18, 2021 12:12
cpcloud
cpcloud approved these changes Sep 18, 2021
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing.

@cpcloud
Copy link
Member

cpcloud commented Sep 18, 2021

@Lunaticus7 Can you rebase this to pick up the fixes to CI?

@cpcloud cpcloud added clickhouse The ClickHouse backend bug Incorrect behavior inside of ibis labels Sep 19, 2021
@cpcloud cpcloud added this to the Next release milestone Sep 19, 2021
@cpcloud cpcloud merged commit cdee091 into ibis-project:master Sep 20, 2021
jreback
jreback reviewed Sep 20, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add a release note describing this change (in docs/source/release)

ibis/backends/clickhouse/tests/test_functions.py
@@ -500,6 +500,19 @@ def test_null_column(alltypes, translate):
tm.assert_series_equal(result, expected)


def test_literal_none_to_nullable_colum(alltypes):
t = alltypes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment to the PR number here

@jreback
Copy link
Contributor

jreback commented Sep 20, 2021

@cpcloud this needed a release note

@cpcloud
Copy link
Member

cpcloud commented Sep 20, 2021

ah whoops, i'll add one in a separate PR

cpcloud added a commit to cpcloud/ibis that referenced this pull request Sep 20, 2021
@cpcloud
docs: add missing release notes for ibis-project#2984 and ibis-projec…
192779f 
…t#2985
@cpcloud cpcloud mentioned this pull request Sep 20, 2021
Merged
@Lunaticus7
Copy link
Contributor Author

@Lunaticus7 Can you rebase this to pick up the fixes to CI?

Thanks for reviewing, and sorry for my absence.
I have a short trip last weekend and haven't check email 😳.

cpcloud added a commit to cpcloud/ibis that referenced this pull request Sep 20, 2021
@cpcloud
docs: add missing release notes for ibis-project#2984 and ibis-projec…
490461d 
…t#2985
cpcloud added a commit that referenced this pull request Sep 20, 2021
@cpcloud
docs: add missing release notes for #2984 and #2985 (#2992)
9832638
@cpcloud cpcloud removed this from the Next release milestone Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

@cpcloud cpcloud cpcloud approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior inside of ibis clickhouse The ClickHouse backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lunaticus7 @cpcloud @jreback