feat(api): add JSON getitem support #4525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
backends
Codecov Report
@@ Coverage Diff @@
## master #4525 +/- ##
=========================================
Coverage ? 92.52%
=========================================
Files ? 184
Lines ? 19922
Branches ? 2935
=========================================
Hits ? 18432
Misses ? 1116
Partials ? 374
|
cpcloud
force-pushed
the
json-getitem
branch
7 times, most recently
from
c1a439f
to
2dce0a1
Compare
kszucs
reviewed
Sep 20, 2022
| class JSONValue(StringValue): | ||
| pass # noqa: E701,E302 | ||
| class JSONValue(Value): | ||
| def __getitem__(self, key): |
There was a problem hiding this comment.
Could you please add a follow-up to provide .get(key, default) API similar to maps?
kszucs
reviewed
Sep 20, 2022
| @@ -27,6 +27,7 @@ class TestConf(UnorderedComparator, BackendTest, RoundHalfToEven): | |||
| supported_to_timestamp_units = {'s'} | |||
| supports_floating_modulus = False | |||
| bool_is_int = True | |||
| supports_json = False | |||
There was a problem hiding this comment.
Please add a follow-up issue to investigate it further.
cpcloud
force-pushed
the
json-getitem
branch
from
2dce0a1
to
d3206f0
Compare
kszucs
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to extract object values or array elements of a JSON-typed column.
Notable things:
clickhouse_driver.JSONtype is return in Python. We handle this here by trying to parse the JSON and if that fails assuming the value is already deserialized.