refactor: rework registration / file loading #5005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gforsyth
force-pushed
the
gil/read_explicit
branch
from
e1ec4ff
to
a3b2256
Compare
Codecov Report
@@ Coverage Diff @@
## master #5005 +/- ##
===========================================
- Coverage 95.08% 82.94% -12.15%
===========================================
Files 401 210 -191
Lines 44763 23259 -21504
Branches 4391 3245 -1146
===========================================
- Hits 42563 19292 -23271
- Misses 1693 3579 +1886
+ Partials 507 388 -119
|
gforsyth
force-pushed
the
gil/read_explicit
branch
from
a3b2256
to
c30e22b
Compare
|
This will close #4906 This is definitely the best way to go about it, regex dispatcher was an issue when I was looking at this |
gforsyth
force-pushed
the
gil/read_explicit
branch
3 times, most recently
from
ec8117c
to
455b677
Compare
gforsyth
changed the title
gforsyth
force-pushed
the
gil/read_explicit
branch
from
455b677
to
df8f6e4
Compare
gforsyth
force-pushed
the
gil/read_explicit
branch
3 times, most recently
from
404ffde
to
34f327e
Compare
cpcloud
reviewed
Jan 5, 2023
gforsyth
force-pushed
the
gil/read_explicit
branch
2 times, most recently
from
48fd0e8
to
d1a025d
Compare
gforsyth
commented
Jan 5, 2023
gforsyth
force-pushed
the
gil/read_explicit
branch
10 times, most recently
from
87ecd8a
to
4ac4045
Compare
Introduces explicit `read_` methods for various types of file / in-memory object loading. Removes the `RegexDispatcher` from the DuckDB, polars, and datafusion backends Should be backwards compatible with existing register functionality, plus users can now pass in iterables of CSV or parquet files (duckdb only), and also make use of the explicit `read_` methods if they choose (say if filenames are non-standard) Somehow, Datafusion can't handle a `count` so I've added a gross conditional to the tests for the moment. This also removes the last usage of RegexDispatcher, so I've removed that from `dispatch.py` and also removed the odo license file, which is now no longer required.
gforsyth
force-pushed
the
gil/read_explicit
branch
from
4ac4045
to
2ef837d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces explicit
read_methods for various types of file /in-memory object loading.
Removes the
RegexDispatcherfrom the DuckDB, polars, and datafusion backendsShould be backwards compatible with existing register functionality,
plus users can now pass in iterables of CSV or parquet files (duckdb only), and also
make use of the explicit
read_methods if they choose (say if filenamesare non-standard)
Somehow, Datafusion can't handle a
countso I've added a grossconditional to the tests for the moment.