fix(backends): make notany/notall work with the where argument
#5993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
bug
cpcloud
force-pushed
the
fix-notany-notall-where
branch
2 times, most recently
from
a37a39f
to
9bff5b2
Compare
cpcloud
force-pushed
the
fix-notany-notall-where
branch
from
9bff5b2
to
12384ad
Compare
gforsyth
reviewed
Apr 13, 2023
| max((`f` = 0) = FALSE) |
There was a problem hiding this comment.
Yeah, not much we can (or IMO should) do about it!
anjakefala
added a commit
to anjakefala/ibis
that referenced
this pull request
Apr 13, 2023
anjakefala
added a commit
to anjakefala/ibis
that referenced
this pull request
Apr 13, 2023
cpcloud
pushed a commit
that referenced
this pull request
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5988. There were multiple issues here, but the primary problem was that we needed to thread the
whereargument through to a few places and enable tests for these APIs.