Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(postgres): port to sqlglot #7877

Merged
merged 1 commit into from
Jan 6, 2024
Merged

refactor(postgres): port to sqlglot #7877

merged 1 commit into from
Jan 6, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jan 2, 2024

Port the postgres backend to sqlglot.

@cpcloud cpcloud added refactor Issues or PRs related to refactoring the codebase postgres The PostgreSQL backend labels Jan 2, 2024
@cpcloud cpcloud force-pushed the tes-postgres branch 9 times, most recently from 9185a7b to ad9f56f Compare January 3, 2024 15:56
@cpcloud
Copy link
Member Author

cpcloud commented Jan 3, 2024

Snowflake tests are passing:

…/ibis on  tes-postgres is 📦 v7.2.0 via 🐍 v3.10.13 via ❄️  impure (ibis-3.10.13-env)
❯ pytest -m snowflake --snapshot-update -n 8 --dist loadgroup -q
bringing up nodes...
xx.x.xxx....x.x.x.x...x....x.x....x..........x...x........x......x.....................x..........x..........xx..x.....x.x.x.x..x....x.......xx.xx.x......xx.............x...........xx....... [ 13%]
.......................................x..............x....x..x....x...x..x...x..........xxxxxx....x.xx.....x.........x.........x............xx.x...x.x.....x..xxx........x....x.xxx..x....... [ 26%]
x..x...x..x.......x.x..............................x..xx..x......x..s...........x.....................x..........x......................x.x............x.......x.......................xx..... [ 39%]
.........x..x.......x.......x.x...........x........x.............x....x..x...........x........x...x....................x...x..........x...............x.x..................xxx................ [ 52%]
......x...x........................xx......x......x.............sx..xxx.x..xxx.x............x....x.xx.....x..x.............x..xx.xx...x...x.......................x...x........x.............x [ 65%]
...x...xx.xx.........x..x.x.x....x......x.......xx..x.x..x...........................................................x...........x.........................x..x......x.x...x.x.........x.x.... [ 78%]
.......x.....x....................x.x............x..x........................xx......x...x..x.........x..xx..x.x.......xx..x..x..xs............x.............................................. [ 91%]
.........................................................................................................................Exception ignored in: <finalize object at 0x7f4c7c09dfa0; dead>
Traceback (most recent call last):
  File "/nix/store/l8d6q4y9cvp2d5qf2sxxj072668bfcjr-python3-3.10.13/lib/python3.10/weakref.py", line 591, in __call__
    return info.func(*info.args, **(info.kwargs or {}))
  File "/nix/store/l8d6q4y9cvp2d5qf2sxxj072668bfcjr-python3-3.10.13/lib/python3.10/tempfile.py", line 860, in _cleanup
    _warnings.warn(warn_message, ResourceWarning)
ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/run/user/1000/tmpe_kd8eac'>
......                                                                [100%]
1259 passed, 3 skipped, 195 xfailed in 135.57s (0:02:15)

@cpcloud cpcloud force-pushed the tes-postgres branch 5 times, most recently from 466c69d to ec6a6e7 Compare January 4, 2024 16:56
@jcrist jcrist mentioned this pull request Jan 4, 2024
Closed
21 tasks
@cpcloud cpcloud force-pushed the tes-postgres branch 4 times, most recently from 3b4604a to 10eff7e Compare January 5, 2024 10:52
kszucs
kszucs reviewed Jan 6, 2024
View reviewed changes
pyproject.toml Show resolved Hide resolved
kszucs
kszucs reviewed Jan 6, 2024
View reviewed changes
ibis/expr/rewrites.py
@@ -239,6 +239,59 @@ def add_one_to_nth_value_input(_, **__):
return _.copy(nth=nth)


@replace(ops.Bucket)
def replace_bucket(_):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this generic to all backends?

@kszucs kszucs enabled auto-merge (squash) January 6, 2024 11:04
@kszucs kszucs merged commit 23e229d into ibis-project:the-epic-split Jan 6, 2024
37 checks passed
@cpcloud cpcloud deleted the tes-postgres branch January 6, 2024 11:08
cpcloud added a commit that referenced this pull request Jan 12, 2024
@cpcloud
refactor(postgres): port to sqlglot (#7877)
bdb4812 
Port the postgres backend to sqlglot.
cpcloud added a commit that referenced this pull request Jan 13, 2024
@cpcloud
refactor(postgres): port to sqlglot (#7877)
0f87e53 
Port the postgres backend to sqlglot.
cpcloud added a commit that referenced this pull request Jan 17, 2024
@cpcloud
refactor(postgres): port to sqlglot (#7877)
2428ea8 
Port the postgres backend to sqlglot.
@kszucs kszucs mentioned this pull request Jan 18, 2024
Merged
gforsyth pushed a commit to gforsyth/ibis that referenced this pull request Jan 18, 2024
@cpcloud @gforsyth
refactor(postgres): port to sqlglot (ibis-project#7877)
52ea0f1 
Port the postgres backend to sqlglot.
@gforsyth gforsyth mentioned this pull request Jan 23, 2024
Merged
@kszucs kszucs mentioned this pull request Feb 1, 2024
Closed
kszucs pushed a commit to kszucs/ibis that referenced this pull request Feb 1, 2024
@cpcloud @kszucs
refactor(postgres): port to sqlglot (ibis-project#7877)
61a2008 
Port the postgres backend to sqlglot.
kszucs pushed a commit to kszucs/ibis that referenced this pull request Feb 1, 2024
@cpcloud @kszucs
refactor(postgres): port to sqlglot (ibis-project#7877)
af6a8da 
Port the postgres backend to sqlglot.
kszucs pushed a commit to kszucs/ibis that referenced this pull request Feb 1, 2024
@cpcloud @kszucs
refactor(postgres): port to sqlglot (ibis-project#7877)
cef710b 
Port the postgres backend to sqlglot.
kszucs pushed a commit to kszucs/ibis that referenced this pull request Feb 2, 2024
@cpcloud @kszucs
refactor(postgres): port to sqlglot (ibis-project#7877)
b942b2d 
Port the postgres backend to sqlglot.
kszucs pushed a commit to kszucs/ibis that referenced this pull request Feb 2, 2024
@cpcloud @kszucs
refactor(postgres): port to sqlglot (ibis-project#7877)
036ad27 
Port the postgres backend to sqlglot.
kszucs pushed a commit to kszucs/ibis that referenced this pull request Feb 2, 2024
@cpcloud @kszucs
refactor(postgres): port to sqlglot (ibis-project#7877)
2876676 
Port the postgres backend to sqlglot.
cpcloud added a commit to cpcloud/ibis that referenced this pull request Feb 4, 2024
@cpcloud
refactor(postgres): port to sqlglot (ibis-project#7877)
2a630bc 
Port the postgres backend to sqlglot.
cpcloud added a commit to cpcloud/ibis that referenced this pull request Feb 5, 2024
@cpcloud
refactor(postgres): port to sqlglot (ibis-project#7877)
73e1b73 
Port the postgres backend to sqlglot.
kszucs pushed a commit that referenced this pull request Feb 5, 2024
@cpcloud @kszucs
refactor(postgres): port to sqlglot (#7877)
d6279a8 
Port the postgres backend to sqlglot.
kszucs pushed a commit that referenced this pull request Feb 6, 2024
@cpcloud @kszucs
refactor(postgres): port to sqlglot (#7877)
0d72d38 
Port the postgres backend to sqlglot.
kszucs pushed a commit that referenced this pull request Feb 6, 2024
@cpcloud @kszucs
refactor(postgres): port to sqlglot (#7877)
f4aa60d 
Port the postgres backend to sqlglot.
cpcloud added a commit to cpcloud/ibis that referenced this pull request Feb 12, 2024
@cpcloud
refactor(postgres): port to sqlglot (ibis-project#7877)
9149c9d 
Port the postgres backend to sqlglot.
cpcloud added a commit that referenced this pull request Feb 12, 2024
@cpcloud
refactor(postgres): port to sqlglot (#7877)
51e0537 
Port the postgres backend to sqlglot.
cpcloud added a commit to cpcloud/ibis that referenced this pull request Feb 12, 2024
@cpcloud
refactor(postgres): port to sqlglot (ibis-project#7877)
8dacd94 
Port the postgres backend to sqlglot.
cpcloud added a commit that referenced this pull request Feb 12, 2024
@cpcloud
refactor(postgres): port to sqlglot (#7877)
c4cc7ff 
Port the postgres backend to sqlglot.
kszucs pushed a commit that referenced this pull request Feb 12, 2024
@cpcloud @kszucs
refactor(postgres): port to sqlglot (#7877)
6916c1d 
Port the postgres backend to sqlglot.
ncclementi pushed a commit to ncclementi/ibis that referenced this pull request Feb 21, 2024
@cpcloud @ncclementi
refactor(postgres): port to sqlglot (ibis-project#7877)
5c77078 
Port the postgres backend to sqlglot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kszucs kszucs kszucs approved these changes

Assignees
No one assigned
Labels
postgres The PostgreSQL backend refactor Issues or PRs related to refactoring the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @kszucs