-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flink): implement UDF support for the backend #8142
feat(flink): implement UDF support for the backend #8142
Conversation
9e93056
to
8dae770
Compare
|
Any chance we can hold off on this for the 8.0 release and target |
Sure! I don't think there's any rush on this. Maybe I'll just keep this branch for now, implement more UDF stuff (since you mentioned TES doesn't affect UDF too much), and then will make whatever changes and/or rebase on top of the new branch, raising a new PR if need be? |
4e988a5
to
1ba34b7
Compare
|
UDF tests pass locally: |
095d3b4
to
89825a3
Compare
c9ce8b8
to
1a83219
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 it!
|
@deepyaman Can we wait for #8398 to be merged? You'll be able to delete some boilerplate in this PR once that one's in. |
|
#8398 is in now |
Sounds good! I'll update this afternoon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to revert the changes in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the other changes are still valid, but I've reverted the (overriding) fallback behaviors.
|
Thanks! |
Description of changes
Issues closed
Resolves #8108