Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(sqlite): port to SQLGlot #8154

Merged
merged 34 commits into from
Jan 31, 2024
Merged

refactor(sqlite): port to SQLGlot #8154

merged 34 commits into from
Jan 31, 2024

Conversation

jcrist
Copy link
Member

@jcrist jcrist commented Jan 30, 2024

Part of #7909.

@jcrist
refactor(sqlite): initial sqlglot backend setup
40d3c46
@jcrist
refactor(sqlite): port string functions to sqlglot
9946a88
@jcrist
refactor(sqlite): port numeric functions to sqlglot
fc538b7
@jcrist
refactor(sqlite): port uuid functions to sqlglot
f824206
@jcrist
refactor(sqlite): port aggregations to sqlglot
6cfd436
@jcrist
refactor(sqlite): skip slow semi join tests for sqlite for now
5f0142a
@jcrist
refactor(sqlite): port array ops to sqlglot
292cbb4
@jcrist
refactor(sqlite): port binary functions to sqlglot
89b2968
@jcrist
refactor(sqlite): fix failing asof join tests
028a711
@jcrist
refactor(sqlite): port .sql to sqlglot
2d0de2a
@jcrist
refactor(sqlite): ensure only register memtable once
c34ebc0
@jcrist
refactor(sqlite): port temporal functionality to sqlglot
a7d88b8
@jcrist
refactor(sqlite): implement con.insert for sqlglot
f44262c
@jcrist
refactor(sqlite): revert sqlite temporal datatype changes
e66c5db
@jcrist
refactor(sqlite): fix rename of temp table
b3ebe9a
@jcrist
refactor(sqlite): fix xor and offset compilation
331462b
@jcrist
refactor(sqlite): fix to_pyarrow/to_pyarrow_batches
9988454
@jcrist
refactor(sqlite): cleaner errors for unsupported dtypes
1c30162
@jcrist
refactor(sqlite): port window functions
c8290a7
@jcrist
refactor(sqlite): port udf functionality
5b6c1c4
@jcrist
refactor(sqlite): fix failing string test
dec8a67
@jcrist
refactor(sqlite): update snapshot tests
01f4dc2
@jcrist
refactor(sqlite): fixups for datatype handling
d7b5a1e
@jcrist
refactor(sqlite): delete some unnecessary tests
e9ae7e5
@jcrist
refactor(sqlite): re-enable CI
89a9e73
@jcrist jcrist mentioned this pull request Jan 30, 2024
Closed
21 tasks
@cpcloud cpcloud added refactor Issues or PRs related to refactoring the codebase sqlite The SQLite backend tes-required-for-release Things that must be addressed before *release* of `main` after merging in `the-epic-split` labels Jan 30, 2024
@cpcloud
Copy link
Member

cpcloud commented Jan 31, 2024

I'll take care of the lockfile mismatch and then merge this!

Thank you!

@cpcloud cpcloud enabled auto-merge (squash) January 31, 2024 00:10
@cpcloud cpcloud merged commit 91d9884 into ibis-project:the-epic-split Jan 31, 2024
56 checks passed
@jcrist jcrist deleted the sqlite-sqlglot-2 branch January 31, 2024 00:31
@kszucs kszucs mentioned this pull request Feb 1, 2024
Closed
kszucs pushed a commit to kszucs/ibis that referenced this pull request Feb 1, 2024
@jcrist @cpcloud @kszucs
refactor(sqlite): port to SQLGlot (ibis-project#8154)
1574b79 
Port the SQLite backend to sqlglot

Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
kszucs pushed a commit to kszucs/ibis that referenced this pull request Feb 1, 2024
@jcrist @cpcloud @kszucs
refactor(sqlite): port to SQLGlot (ibis-project#8154)
30c0a3f 
Port the SQLite backend to sqlglot

Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
kszucs pushed a commit to kszucs/ibis that referenced this pull request Feb 1, 2024
@jcrist @cpcloud @kszucs
refactor(sqlite): port to SQLGlot (ibis-project#8154)
2a3afd0 
Port the SQLite backend to sqlglot

Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
kszucs pushed a commit to kszucs/ibis that referenced this pull request Feb 2, 2024
@jcrist @cpcloud @kszucs
refactor(sqlite): port to SQLGlot (ibis-project#8154)
40d86ba 
Port the SQLite backend to sqlglot

Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
kszucs pushed a commit to kszucs/ibis that referenced this pull request Feb 2, 2024
@jcrist @cpcloud @kszucs
refactor(sqlite): port to SQLGlot (ibis-project#8154)
406c85a 
Port the SQLite backend to sqlglot

Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
kszucs pushed a commit to kszucs/ibis that referenced this pull request Feb 2, 2024
@jcrist @cpcloud @kszucs
refactor(sqlite): port to SQLGlot (ibis-project#8154)
0a088e5 
Port the SQLite backend to sqlglot

Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
cpcloud added a commit to cpcloud/ibis that referenced this pull request Feb 4, 2024
@jcrist @cpcloud
refactor(sqlite): port to SQLGlot (ibis-project#8154)
ee83fae 
Port the SQLite backend to sqlglot

Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
cpcloud added a commit to cpcloud/ibis that referenced this pull request Feb 5, 2024
@jcrist @cpcloud
refactor(sqlite): port to SQLGlot (ibis-project#8154)
a4ded83 
Port the SQLite backend to sqlglot

Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
kszucs pushed a commit that referenced this pull request Feb 5, 2024
@jcrist @cpcloud @kszucs
refactor(sqlite): port to SQLGlot (#8154)
6ca8425 
Port the SQLite backend to sqlglot

Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
kszucs pushed a commit that referenced this pull request Feb 6, 2024
@jcrist @cpcloud @kszucs
refactor(sqlite): port to SQLGlot (#8154)
4adaf2b 
Port the SQLite backend to sqlglot

Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
kszucs pushed a commit that referenced this pull request Feb 6, 2024
@jcrist @cpcloud @kszucs
refactor(sqlite): port to SQLGlot (#8154)
1b7ee69 
Port the SQLite backend to sqlglot

Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
cpcloud added a commit to cpcloud/ibis that referenced this pull request Feb 12, 2024
@jcrist @cpcloud
refactor(sqlite): port to SQLGlot (ibis-project#8154)
95158bf 
Port the SQLite backend to sqlglot

Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
cpcloud added a commit that referenced this pull request Feb 12, 2024
@jcrist @cpcloud
refactor(sqlite): port to SQLGlot (#8154)
381fbe2 
Port the SQLite backend to sqlglot

Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
cpcloud added a commit to cpcloud/ibis that referenced this pull request Feb 12, 2024
@jcrist @cpcloud
refactor(sqlite): port to SQLGlot (ibis-project#8154)
5bd0cfc 
Port the SQLite backend to sqlglot

Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
cpcloud added a commit that referenced this pull request Feb 12, 2024
@jcrist @cpcloud
refactor(sqlite): port to SQLGlot (#8154)
27844ad 
Port the SQLite backend to sqlglot

Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
kszucs pushed a commit that referenced this pull request Feb 12, 2024
@jcrist @cpcloud @kszucs
refactor(sqlite): port to SQLGlot (#8154)
4d24502 
Port the SQLite backend to sqlglot

Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
ncclementi pushed a commit to ncclementi/ibis that referenced this pull request Feb 21, 2024
@jcrist @cpcloud @ncclementi
refactor(sqlite): port to SQLGlot (ibis-project#8154)
c13487d 
Port the SQLite backend to sqlglot

Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

@kszucs kszucs kszucs left review comments

Assignees
No one assigned
Labels
refactor Issues or PRs related to refactoring the codebase sqlite The SQLite backend tes-required-for-release Things that must be addressed before *release* of `main` after merging in `the-epic-split`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcrist @cpcloud @kszucs