Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add v8 blog #8200

Merged
merged 11 commits into from
Feb 12, 2024
Merged

docs: add v8 blog #8200

merged 11 commits into from
Feb 12, 2024

Conversation

lostmygithubaccount
Copy link
Member

Description of changes

Ibis does streaming! and more

Issues closed

@lostmygithubaccount lostmygithubaccount added the docs Documentation related issues or PRs label Feb 2, 2024
@lostmygithubaccount lostmygithubaccount added this to the 8.0 milestone Feb 2, 2024
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Feb 2, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Feb 2, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Feb 2, 2024

Docs preview: https://pr-8200-2038a995e28e87e9292133bddcd4a0bda0abc540--ibis-quarto.netlify.app

gforsyth
gforsyth reviewed Feb 2, 2024
View reviewed changes
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a collection of nits.

also, in the added functionality, do we want to link to the API docs for the methods being called out?

docs/posts/ibis-version-v8-release/index.qmd Outdated

## Overview

Ibis v8 marks the first release of data streaming backends in Ibis! We're
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v8 vs. 8.0?
are we going for the tomato juice market or the webassembly market?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer v8 but might be missing some nuance there

docs/posts/ibis-version-v8-release/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-version-v8-release/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-version-v8-release/index.qmd Outdated
Comment on lines 31 to 32
Ibis now supports both and going forward can add more streaming backends to
unify the Python user experience across batch and streaming systems.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a qualifier here -- in some respects we've already unified this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how if we didn't have a streaming backend before?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's the unclear antecedent.

What is allowing the unification? That we "now support both" or that "going forward [we] can add more to unify..."

docs/posts/ibis-version-v8-release/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-version-v8-release/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-version-v8-release/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-version-v8-release/index.qmd Outdated Show resolved Hide resolved
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Feb 2, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Feb 2, 2024
@lostmygithubaccount
Copy link
Member Author

@gforsyth I am just worried links would break; they can always search in the top right...

@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Feb 2, 2024

Docs preview: https://pr-8200-e4b61b0d6f2bb98ce421019a9704e7008fb76dfb--ibis-quarto.netlify.app

@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Feb 2, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Feb 2, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Feb 2, 2024

Docs preview: https://pr-8200-fb33b2bc5070e5321315494001c92659ed0d9083--ibis-quarto.netlify.app

@deepyaman deepyaman mentioned this pull request Feb 2, 2024
Merged
lostmygithubaccount
lostmygithubaccount commented Feb 2, 2024
View reviewed changes
docs/posts/ibis-v8-release/index.qmd Outdated
Comment on lines 76 to 83
Flink](../../backends/flink.qmd). You can check out the [blog post](TODO: link)
and [tutorial](TODO: link) to get started with this new backend.

### RisingWave

In collboration with [RisingWave](https://risingwave.com), we've added the
[second streaming backend with RisingWave](../../backends/flink.qmd) # TODO:
update. This backend is earlier in development, but we're excited to have it as
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not merge w/ these TODOs

zhenzhongxu
zhenzhongxu suggested changes Feb 3, 2024
View reviewed changes
Copy link
Contributor

@zhenzhongxu zhenzhongxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions on concepts and nit asks.

docs/posts/ibis-v8-release/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-v8-release/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-v8-release/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-v8-release/index.qmd Outdated Show resolved Hide resolved
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Feb 5, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Feb 5, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Feb 5, 2024

Docs preview: https://pr-8200-cd1365ddd19a96259d3050f17c6ea6bbc4aac68b--ibis-quarto.netlify.app

zhenzhongxu
zhenzhongxu approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@zhenzhongxu zhenzhongxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cpcloud cpcloud removed this from the 8.0 milestone Feb 5, 2024
@lostmygithubaccount lostmygithubaccount marked this pull request as ready for review February 12, 2024 14:41
@lostmygithubaccount lostmygithubaccount merged commit 4adb5e3 into ibis-project:main Feb 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gforsyth gforsyth gforsyth left review comments

@cpcloud cpcloud cpcloud approved these changes

@zhenzhongxu zhenzhongxu zhenzhongxu approved these changes

Assignees
No one assigned
Labels
docs Documentation related issues or PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lostmygithubaccount @cpcloud @zhenzhongxu @gforsyth