Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ir): remove now obsolete ops.Named mixin #8244

Merged
merged 4 commits into from
Feb 6, 2024

Conversation

kszucs
Copy link
Member

@kszucs kszucs commented Feb 6, 2024

Named mixin is not really used anymore. Remove it in favor of getattr("name").

Copy link
Contributor

github-actions bot commented Feb 6, 2024

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

@kszucs kszucs force-pushed the remove-named branch 2 times, most recently from b30928c to be478e3 Compare February 6, 2024 14:09
@kszucs kszucs force-pushed the remove-named branch 2 times, most recently from c6fc81d to 6914c8b Compare February 6, 2024 14:51
@cpcloud
Copy link
Member

cpcloud commented Feb 6, 2024

I'll regenerate the impala snapshots

@cpcloud cpcloud changed the title refactor(ir): remove now obsolete ops.Named mixin refactor(ir): remove now obsolete ops.Named mixin Feb 6, 2024
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cpcloud cpcloud added this to the 9.0 milestone Feb 6, 2024
@cpcloud cpcloud added the refactor Issues or PRs related to refactoring the codebase label Feb 6, 2024
@cpcloud cpcloud merged commit 6a017f1 into ibis-project:the-epic-split Feb 6, 2024
68 checks passed
@kszucs kszucs deleted the remove-named branch February 6, 2024 18:24
cpcloud added a commit to cpcloud/ibis that referenced this pull request Feb 12, 2024
Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
cpcloud added a commit that referenced this pull request Feb 12, 2024
Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
cpcloud added a commit to cpcloud/ibis that referenced this pull request Feb 12, 2024
Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
cpcloud added a commit that referenced this pull request Feb 12, 2024
Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
kszucs added a commit that referenced this pull request Feb 12, 2024
Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
ncclementi pushed a commit to ncclementi/ibis that referenced this pull request Feb 21, 2024
Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues or PRs related to refactoring the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants