Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datatypes): convert UUIDs to strings #8262

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Feb 7, 2024

Fixes #8261.

@cpcloud cpcloud added this to the 9.0 milestone Feb 7, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis ux User experience related issues datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) labels Feb 7, 2024
@cpcloud cpcloud changed the title fix uuid formatting fix(datatypes): convert UUIDs to strings Feb 7, 2024
Copy link
Contributor

github-actions bot commented Feb 7, 2024

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

@cpcloud
Copy link
Member Author

cpcloud commented Feb 7, 2024

Confirming this fixes the repr:

In [3]: from ibis.interactive import *

In [4]: con = ibis.duckdb.connect()

In [5]: con.sql("select uuid()")
Out[5]:
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ uuid()                               ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┩
│ uuid                                 │
├──────────────────────────────────────┤
│ 46bdc7b4-152c-43b7-8f8a-8d136a8cc7dd │
└──────────────────────────────────────┘

@NickCrews
Copy link
Contributor

This looks good, thanks @cpcloud !

Assuming that we don't want to actually ship a pyarrow extension type (they have a uuid example there)?

Copy link
Member

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix

@cpcloud
Copy link
Member Author

cpcloud commented Feb 7, 2024

This looks good, thanks @cpcloud !

Assuming that we don't want to actually ship a pyarrow extension type (they have a uuid example there)?

Eventually maybe, but not in this PR :)

@cpcloud
Copy link
Member Author

cpcloud commented Feb 7, 2024

Extension types run the risk of creating type fiefdoms, and that's not good for ibis because we have to interact with downstream systems. Placing a burden on them to understand our PyArrow extension types is asking quite a lot.

@cpcloud cpcloud merged commit 6f32374 into ibis-project:main Feb 7, 2024
82 of 83 checks passed
@cpcloud cpcloud deleted the fix-uuid-formatting branch February 7, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) ux User experience related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: can't preview table containing UUIDs
3 participants