-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datatypes): convert UUIDs to strings #8262
Conversation
|
ACTION NEEDED Ibis follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
|
Confirming this fixes the repr: |
|
This looks good, thanks @cpcloud ! Assuming that we don't want to actually ship a pyarrow extension type (they have a uuid example there)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix
Eventually maybe, but not in this PR :) |
|
Extension types run the risk of creating type fiefdoms, and that's not good for ibis because we have to interact with downstream systems. Placing a burden on them to understand our PyArrow extension types is asking quite a lot. |
Fixes #8261.