Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trino): re-enable native TABLESAMPLE support #8284

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

jcrist
Copy link
Member

@jcrist jcrist commented Feb 8, 2024

This was implemented natively on main, but got lost in the refactor.

Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, thank you!

@cpcloud cpcloud added this to the 9.0 milestone Feb 8, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis trino The Trino backend labels Feb 8, 2024
@cpcloud cpcloud enabled auto-merge (squash) February 8, 2024 17:06
@cpcloud cpcloud merged commit 9b72fc0 into ibis-project:the-epic-split Feb 8, 2024
69 checks passed
@jcrist jcrist deleted the trino-tablesample branch February 8, 2024 17:17
cpcloud pushed a commit to cpcloud/ibis that referenced this pull request Feb 12, 2024
cpcloud pushed a commit to cpcloud/ibis that referenced this pull request Feb 12, 2024
ncclementi pushed a commit to ncclementi/ibis that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis trino The Trino backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants