Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): include bad type in NotImplementedError #8291

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

NickCrews
Copy link
Contributor

@NickCrews NickCrews commented Feb 8, 2024

Tiny little improvement. I was running into this, and this would have made it easier to debug.

I was running into this, and this would have made it easier to debug.
@cpcloud
Copy link
Member

cpcloud commented Feb 9, 2024

Thanks!

@cpcloud cpcloud added this to the 9.0 milestone Feb 9, 2024
@cpcloud cpcloud added the ux User experience related issues label Feb 9, 2024
@cpcloud cpcloud changed the title feat: include bad type in NotImplementedError feat(api): include bad type in NotImplementedError Feb 9, 2024
@cpcloud cpcloud merged commit 36da06b into ibis-project:main Feb 9, 2024
84 checks passed
@NickCrews NickCrews deleted the better-join-err-msg branch February 13, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux User experience related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants