refactor(deps): remove multipledispatch as a dependency
#8332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
refactor
|
The approach looks good to me, going to have a more thorough look. |
kszucs
reviewed
Feb 13, 2024
| @@ -46,166 +43,3 @@ def highest_precedence(dtypes: Iterator[dt.DataType]) -> dt.DataType: | |||
| return functools.reduce(higher_precedence, collected) | |||
| else: | |||
| return dt.null | |||
|
|
|||
|
|
|||
| @castable.register(dt.DataType, dt.DataType) | |||
There was a problem hiding this comment.
Shall we have function for backward compatibility?
There was a problem hiding this comment.
I don't think so, this isn't a public API.
There was a problem hiding this comment.
How about removing dt.cast() as well then in favor of the cast() method?
There was a problem hiding this comment.
That one I would rather do in a follow up
kszucs
reviewed
Feb 13, 2024
cpcloud
force-pushed
the
remove-multipledispatch
branch
2 times, most recently
from
99b42f3
to
bb1a2c5
Compare
cpcloud
force-pushed
the
remove-multipledispatch
branch
from
bb1a2c5
to
7b4e312
Compare
kszucs
approved these changes
Feb 13, 2024
ncclementi
pushed a commit
to ncclementi/ibis
that referenced
this pull request
Feb 21, 2024
…ct#8332) This PR removes `multipledispatch` as a dependency of Ibis. After `the-epic-split` was merged our largest consumer of `multipledispatch` was removed, now there is this remaining bit of code to port over to use non-multipledispatch-style checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
multipledispatchas a dependency of Ibis. Afterthe-epic-splitwas merged our largest consumer ofmultipledispatchwas removed, now there is this remaining bit of code to port over to use non-multipledispatch-style checks.