refactor(sql): automatically add simple ops implementations #8349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
refactor
|
Looks like I'm on the road to breaking ... everything! |
cpcloud
force-pushed
the
cleanup-simple-ops
branch
4 times, most recently
from
394450d
to
bee593f
Compare
kszucs
reviewed
Feb 14, 2024
kszucs
reviewed
Feb 14, 2024
| ops.IntervalMultiply: sge.Mul, | ||
| ops.IntervalSubtract: sge.Sub, | ||
| } | ||
|
|
||
| def __init__(self) -> None: | ||
| self.agg = AggGen(aggfunc=self._aggregate) | ||
| self.f = FuncGen() | ||
| self.v = VarGen() | ||
|
|
||
| def __init_subclass__(cls, **kwargs): |
There was a problem hiding this comment.
So the only reason we need to construct and attach methods here is because of has_operation looks for the method? Couldn't we move this logic into a handler which would compile all value nodes if those are not explicitly overwritten?
There was a problem hiding this comment.
like
def visit(...):
method_name = ...
if self.hasattr(method_name):
call that specific method
else:
self.visit_Value() # which would handle simple opsthen has_operation would condier the cls.SIMPLE_OPS mapping
There was a problem hiding this comment.
Maybe, but I don't want to spend time making this improvement perfect here. If you have an idea for a further improvement, that can be done in a follow up.
cpcloud
force-pushed
the
cleanup-simple-ops
branch
from
bee593f
to
c513e62
Compare
cpcloud
force-pushed
the
cleanup-simple-ops
branch
from
c513e62
to
b4e5b72
Compare
cpcloud
added
ci-run-cloud
ibis-docs-bot
bot
removed
docs-preview
ibis-docs-bot
bot
removed
the
docs-preview
|
Doesn't seem like my CI fixes for label running helped 😞 |
cpcloud
added
the
ci-run-cloud
ibis-docs-bot
bot
removed
the
ci-run-cloud
kszucs
reviewed
Feb 14, 2024
kszucs
reviewed
Feb 14, 2024
kszucs
approved these changes
Feb 14, 2024
ncclementi
pushed a commit
to ncclementi/ibis
that referenced
this pull request
Feb 21, 2024
…ject#8349) Follow up to ibis-project#8338 to clean up the SIMPLE_OPS boilerplate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #8338 to clean up the SIMPLE_OPS boilerplate.