Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing dev docker instructions for backends #8352

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

ncclementi
Copy link
Contributor

We have some new backends and old ones that are not listed in the contribute section, I'm adding them. in this PR.

I also noticed that we don't have instructions on how to tests Bigquery and Snowflake. My guess is that we have some limitations in terms of exposing resources for that? We might want to have a note about that.

Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
@cpcloud cpcloud enabled auto-merge (squash) February 14, 2024 15:40
@ncclementi
Copy link
Contributor Author

I also noticed that we don't have instructions on how to tests Bigquery and Snowflake. My guess is that we have some limitations in terms of exposing resources for that? We might want to have a note about that.

@cpcloud Do you think a note saying something like:

"Note: If you are interested in contributing to the BigQuery or Snowflake backends, please contact the team by opening an issue"

@cpcloud cpcloud merged commit a20f44a into ibis-project:main Feb 14, 2024
15 checks passed
@cpcloud
Copy link
Member

cpcloud commented Feb 14, 2024

@ncclementi Yeah, that seems fine!

ncclementi added a commit to ncclementi/ibis that referenced this pull request Feb 21, 2024
…8352)

Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants