fix(flink): fix compilation of over aggregation query in flink backend #8359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloeh13q
force-pushed
the
fix/flink-over-window
branch
3 times, most recently
from
84c5e3e
to
438846d
Compare
zhenzhongxu
reviewed
Feb 23, 2024
chloeh13q
force-pushed
the
fix/flink-over-window
branch
from
764c835
to
2576d70
Compare
cpcloud
reviewed
Feb 23, 2024
cpcloud
approved these changes
Feb 23, 2024
cpcloud
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR fixes the compilation of over aggregation query in Flink backend.
I identified the following issues:
ibis.interval(minutes=500)compiles to `INTERVAL '500' MINUTE, which throwsrange=(-ibis.interval(minutes=500), 0)compiles to[...] AND CAST(0 AS INTERVAL MINUTE)following and Flink doesn't support rows/range following in over aggregation. This throwsI also removed the unused test snapshot directory that didn't get cleaned up.
Issues closed