Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(duckdb-sql): ignore importlib package errors when importing ibis.snowflake for transpilation #8389

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Feb 18, 2024

Fixes an issue where we try to pluck package metadata for a non-existent package (snowflake-connector-python) when transpiling from one dialect to another; in this case duckdb sql to snowflake sql.

@cpcloud cpcloud added this to the 9.0 milestone Feb 18, 2024
@cpcloud cpcloud added dependencies Issues or PRs related to dependencies duckdb The DuckDB backend snowflake The Snowflake backend labels Feb 18, 2024
@cpcloud
Copy link
Member Author

cpcloud commented Feb 18, 2024

This should get main passing again.

@cpcloud cpcloud merged commit b968301 into ibis-project:main Feb 18, 2024
73 of 74 checks passed
@cpcloud cpcloud deleted the fix-snowflake-deps-when-running-duckdb-to-sql branch February 18, 2024 12:24
ncclementi pushed a commit to ncclementi/ibis that referenced this pull request Feb 21, 2024
…snowflake for transpilation (ibis-project#8389)

Fixes an issue where we try to pluck package metadata for a non-existent
package (`snowflake-connector-python`) when transpiling from one dialect
to another; in this case duckdb sql to snowflake sql.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issues or PRs related to dependencies duckdb The DuckDB backend snowflake The Snowflake backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant