Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(udfs): consolidate builtin udf compilation and failure modes for unimplemented udfs #8398

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Feb 20, 2024

Removes dupcliated udf registration and default failure mode logic for sql backends.

@cpcloud cpcloud added this to the 9.0 milestone Feb 20, 2024
@cpcloud cpcloud added refactor Issues or PRs related to refactoring the codebase udf Issues related to user-defined functions labels Feb 20, 2024
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@gforsyth gforsyth changed the title refactor(udfs): conslidate builtin udf compilation and failure modes for unimplemented udfs refactor(udfs): consolidate builtin udf compilation and failure modes for unimplemented udfs Feb 20, 2024
@gforsyth gforsyth merged commit 0320d01 into ibis-project:main Feb 20, 2024
73 checks passed
@cpcloud cpcloud deleted the builtin-udf-base-impl branch February 20, 2024 19:04
ncclementi pushed a commit to ncclementi/ibis that referenced this pull request Feb 21, 2024
… for unimplemented udfs (ibis-project#8398)

Removes duplicated udf registration and default failure mode logic for
sql backends.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues or PRs related to refactoring the codebase udf Issues related to user-defined functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants