Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(modules): remove unnecessary base submodule #8405

Merged
merged 2 commits into from
Feb 21, 2024
Merged

refactor(modules): remove unnecessary base submodule #8405

merged 2 commits into from
Feb 21, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Feb 21, 2024

This PR removes an unnecessary level in the ibis.backends hierarchy and replaces SQLGlotBackend with SQLBackend.

@cpcloud cpcloud added this to the 9.0 milestone Feb 21, 2024
@cpcloud cpcloud added the refactor Issues or PRs related to refactoring the codebase label Feb 21, 2024
@cpcloud cpcloud mentioned this pull request Feb 21, 2024
Merged
@gforsyth gforsyth added the ci-run-cloud Add this label to trigger a run of BigQuery, Snowflake, and Databricks backends in CI label Feb 21, 2024
gforsyth
gforsyth approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SMASH REDUNDANT HIERARCHY SMASH

@ibis-docs-bot ibis-docs-bot bot removed the ci-run-cloud Add this label to trigger a run of BigQuery, Snowflake, and Databricks backends in CI label Feb 21, 2024
@cpcloud
Copy link
Member Author

cpcloud commented Feb 21, 2024

Ah, thanks for running the ☁️s

@cpcloud cpcloud merged commit 6946f98 into ibis-project:main Feb 21, 2024
88 checks passed
@cpcloud cpcloud deleted the remove-base-subpackage branch February 21, 2024 19:14
gforsyth pushed a commit that referenced this pull request Feb 21, 2024
@cpcloud
refactor(backend-api): remove the database() API and implementation (…
ff5d078 
…#8406)

Remove the `BaseBackend.database()` API. This has been deprecated for a
quite a while. Depends on #8405.
@deepyaman deepyaman mentioned this pull request May 10, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gforsyth gforsyth gforsyth approved these changes

Assignees
No one assigned
Labels
refactor Issues or PRs related to refactoring the codebase
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @gforsyth