fix(mssql): restore any, all and cumulative versions #8409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I took a look through what sqlalchemy was generating for these failing test cases and then reimplemented it using sqlglot. Any and All: * Instead of `logical or` we do a `Max(IIF(condition, 1, 0))` * Instead of `logical and` we do a `Min(IIF(condition, 1, 0))` Cumulative versions: The cumulative versions work, but required an additional check in the `visit_Not` node. MSSQL doesn't support doing `IFF(MAX(IFF(...` -- the argument to IFF has to be a boolean and the Window function isn't considered a boolean for some reason, so the outer conditional needs to be a case statement.
|
Wonderful, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I took a look through what sqlalchemy was generating for these failing
test cases and then reimplemented it using sqlglot.
Any and All:
logical orwe do aMax(IIF(condition, 1, 0))logical andwe do aMin(IIF(condition, 1, 0))Cumulative versions:
The cumulative versions work, but required an additional check in the
visit_Notnode. MSSQL doesn't support doingIFF(MAX(IFF(...-- theargument to IFF has to be a boolean and the Window function isn't
considered a boolean for some reason, so the outer conditional needs to
be a case statement.- fix(mssql): restore any, all and cumulative versions
Issues closed
any/alland cumulative versions #8073