Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ir): remove find_first_base_table() analysis function #8451

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

kszucs
Copy link
Member

@kszucs kszucs commented Feb 26, 2024

There were just a couple of places left where find_first_base_table() was still in use. Since the epic split refactor the preferred way to retrieve parent relation(s) is the value.relations property.

Copy link
Member

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

ibis/expr/types/generic.py Outdated Show resolved Hide resolved
@kszucs kszucs enabled auto-merge (squash) February 27, 2024 08:10
@kszucs kszucs merged commit 5cbd472 into ibis-project:main Feb 27, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants