refactor(oracle): remove dependency on private function for temp tables #8480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gforsyth
force-pushed
the
oracle/temp_table_sqlglot
branch
from
d2d8b22
to
c98e96a
Compare
Upcoming changes in `sqlglot` remove the `create_with_partitions_sql` helper from `sqlglot.dialects.dialect` and the way I was using it was a little weird anyway. This should be a little less brittle as things change upstream.
gforsyth
force-pushed
the
oracle/temp_table_sqlglot
branch
from
c98e96a
to
5a1725a
Compare
cpcloud
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The previous workaround for temp tables in Oracle was quite brittle and broke
when I tried to bump our upper pin on
sqlglot. I've refactored it to be(hopefully) less brittle
and also bumped thesqlglotpin up a few versions.Dropping the version bump from this PR, there are some breaking changes for postgres, risingwave, and trino, looks like.